Skip to content

Commit

Permalink
cleanup unused deps
Browse files Browse the repository at this point in the history
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
  • Loading branch information
BugenZhao committed Dec 10, 2024
1 parent c49d2fc commit 291d1bf
Show file tree
Hide file tree
Showing 5 changed files with 21 additions and 65 deletions.
29 changes: 0 additions & 29 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 0 additions & 14 deletions src/batch/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -15,18 +15,12 @@ normal = ["workspace-hack"]

[dependencies]
anyhow = "1"
assert_matches = "1"
async-recursion = "1"
async-trait = "0.1"
bytes = "1"
chrono = "0.4"
either = "1"
foyer = { workspace = true }
futures = { version = "0.3", default-features = false, features = ["alloc"] }
futures-async-stream = { workspace = true }
futures-util = "0.3"
hashbrown = { workspace = true }
hytra = "0.1.2"
iceberg = { workspace = true }
itertools = { workspace = true }
linkme = { workspace = true }
Expand All @@ -35,21 +29,16 @@ mysql_async = { workspace = true }
opendal = { workspace = true }
parking_lot = { workspace = true }
parquet = { workspace = true }
paste = "1"
prometheus = { version = "0.13", features = ["process"] }
prost = { workspace = true }
rand = { workspace = true }
risingwave_common = { workspace = true }
risingwave_common_estimate_size = { workspace = true }
risingwave_connector = { workspace = true }
risingwave_dml = { workspace = true }
risingwave_expr = { workspace = true }
risingwave_hummock_sdk = { workspace = true }
risingwave_pb = { workspace = true }
risingwave_rpc_client = { workspace = true }
risingwave_storage = { workspace = true }
rust_decimal = "1"
rw_futures_util = { workspace = true }
scopeguard = "1"
serde_json = "1"
thiserror = "1"
Expand All @@ -63,14 +52,11 @@ tokio = { version = "0.2", package = "madsim-tokio", features = [
"signal",
"fs",
] }
tokio-metrics = "0.3.0"
tokio-postgres = "0.7"
tokio-stream = { workspace = true }
tokio-util = { workspace = true }
tonic = { workspace = true }
tracing = "0.1"
twox-hash = "1"
uuid = { version = "1", features = ["v4"] }

[target.'cfg(not(madsim))'.dependencies]
workspace-hack = { path = "../workspace-hack" }
Expand Down
15 changes: 0 additions & 15 deletions src/batch/executors/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -16,28 +16,20 @@ normal = ["workspace-hack"]
[dependencies]
anyhow = "1"
assert_matches = "1"
async-recursion = "1"
async-trait = "0.1"
bytes = "1"
chrono = "0.4"
either = "1"
foyer = { workspace = true }
futures = { version = "0.3", default-features = false, features = ["alloc"] }
futures-async-stream = { workspace = true }
futures-util = "0.3"
hashbrown = { workspace = true }
hytra = "0.1.2"
iceberg = { workspace = true }
itertools = { workspace = true }
linkme = { workspace = true }
memcomparable = "0.2"
mysql_async = { workspace = true }
opendal = { workspace = true }
parking_lot = { workspace = true }
parquet = { workspace = true }
paste = "1"
prometheus = { version = "0.13", features = ["process"] }
prost = { workspace = true }
rand = { workspace = true }
risingwave_batch = { workspace = true }
risingwave_common = { workspace = true }
Expand All @@ -49,11 +41,8 @@ risingwave_hummock_sdk = { workspace = true }
risingwave_pb = { workspace = true }
risingwave_rpc_client = { workspace = true }
risingwave_storage = { workspace = true }
rust_decimal = "1"
rw_futures_util = { workspace = true }
scopeguard = "1"
serde_json = "1"
thiserror = "1"
thiserror-ext = { workspace = true }
tokio = { version = "0.2", package = "madsim-tokio", features = [
"rt",
Expand All @@ -64,13 +53,9 @@ tokio = { version = "0.2", package = "madsim-tokio", features = [
"signal",
"fs",
] }
tokio-metrics = "0.3.0"
tokio-postgres = "0.7"
tokio-stream = { workspace = true }
tokio-util = { workspace = true }
tonic = { workspace = true }
tracing = "0.1"
twox-hash = "1"
uuid = { version = "1", features = ["v4"] }

[target.'cfg(not(madsim))'.dependencies]
Expand Down
14 changes: 7 additions & 7 deletions src/batch/executors/benches/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,28 +7,28 @@ We use [criterion](https://bheisler.github.io/criterion.rs/book/index.html) micr
Run all benchmarks

```bash
cargo bench -p risingwave_batch
cargo bench -p risingwave_batch_executors
```

Run a specific benchmark

```bash
cargo bench -p risingwave_batch -- <filter>
cargo bench -p risingwave_batch_executors -- <filter>
```

where `<filter>` is a regular expression matching the benchmark ID, e.g.,
`top_n.rs` uses `BenchmarkId::new("TopNExecutor", params)` , so we can run TopN benchmarks with

```bash
# All TopN benchmarks
cargo bench -p risingwave_batch -- TopN
cargo bench -p risingwave_batch_executors -- TopN
# One specific setting of TopN benchmarks
cargo bench -p risingwave_batch -- "TopNExecutor/2048\(single_column: true\)"
cargo bench -p risingwave_batch_executors -- "TopNExecutor/2048\(single_column: true\)"
```

> *Note*: `-p risingwave_batch` can be omitted if you are in the `src/batch` directory.
> *Note*: `-p risingwave_batch_executors` can be omitted if you are in the `src/batch/executors` directory.
## Add new Benchmarks

* Add benchmark target to `src/batch/Cargo.toml`
* Implement benchmarks in `src/batch/benches`, referring to existing ones
* Add benchmark target to `src/batch/executors/Cargo.toml`
* Implement benchmarks in `src/batch/executors/benches`, referring to existing ones
14 changes: 14 additions & 0 deletions src/batch/executors/src/lib.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,17 @@
// Copyright 2024 RisingWave Labs
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

#![allow(clippy::derive_partial_eq_without_eq)]
#![feature(trait_alias)]
#![feature(exact_size_is_empty)]
Expand Down

0 comments on commit 291d1bf

Please sign in to comment.