Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve compile errors when feature optimism is on #5

Closed
wants to merge 1 commit into from

Conversation

kien-rise
Copy link

Steps to verify

  1. Go to crates/optimism/bin/Cargo.toml, enable feature optimism:
-default = ["jemalloc"]
+default = ["jemalloc", "optimism"]
  1. Run cargo clippy or cargo build --package op-reth

@kien-rise kien-rise requested a review from hai-rise October 29, 2024 20:21
{
return Err(BlockValidationError::TransactionGasLimitMoreThanAvailableBlockGas {
transaction_gas_limit: transaction.gas_limit(),
block_available_gas,
}
.into())
.into());

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nit but Reth actually uses nightly rustfmt with a specific rule to skip these dangling semicolons.

@hai-rise
Copy link

hai-rise commented Oct 30, 2024

@kien-rise We should focus on block-building for the first pevm integration into RISE Stack so let's not base on this historical-sync branch. I meant to create a new branch without realizing the name conflict with this existing one...

So basically, let's try our best to not use a Reth fork in the RISE Stack. If we must, let's create a new branch with minimal changes to support the pevm block builder first.

@kien-rise
Copy link
Author

So basically, let's try our best to not use a Reth fork in the RISE Stack. If we must, let's create a new branch with minimal changes to support the pevm block builder first.

Alright, will use this reth fork: https://github.com/risechain/reth/commits/pevm-integration/

Future PRs (if any) will target this branch (pevm-integration).

Note that the "minimal changes" is not so small. As long as we use our modified revm, the code changes on reth is inevitable.

@kien-rise kien-rise closed this Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants