feat(tsf): enable language bar button #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prcuvu
reviewed
Apr 5, 2018
WeaselTSF/LanguageBar.cpp
Outdated
| @@ -137,7 +141,7 @@ STDAPI CLangBarItemButton::Show(BOOL fShow) | |||
|
|
|||
| STDAPI CLangBarItemButton::GetTooltipString(BSTR *pbstrToolTip) | |||
| { | |||
| *pbstrToolTip = SysAllocString(L"左鍵切換模式，右鍵打開菜單"); | |||
| *pbstrToolTip = SysAllocString(L"右鍵打開菜單"); | |||
There was a problem hiding this comment.
It would be better to implement ascii_mode switch on language bar icon click.
lotem
reviewed
Apr 7, 2018
weasel.sln
Outdated
| @@ -1,13 +1,14 @@ | |||
| | |||
| Microsoft Visual Studio Solution File, Format Version 12.00 | |||
| # Visual Studio 14 | |||
| VisualStudioVersion = 14.0.25420.1 | |||
| # Visual Studio 15 | |||
There was a problem hiding this comment.
Auto generated by IDE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.