Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

把 menu/page_size 设置成大于 10 的整数，当前编码候选项大于 10 时会发生 UI 显示错误 #121

Closed
Prcuvu opened this issue Feb 28, 2018 · 0 comments
Closed

把 menu/page_size 设置成大于 10 的整数，当前编码候选项大于 10 时会发生 UI 显示错误 #121

Prcuvu opened this issue Feb 28, 2018 · 0 comments
Assignees
@lotem
Labels
Bug

Comments

@Prcuvu
Copy link
Contributor

Prcuvu commented Feb 28, 2018 •
edited
Loading

设置 stroke.custom.yaml：

patch:
  menu/page_size: 11

重新部署后输入编码，结果如下图所示。

image

是否应该限制 menu/page_size 的最大值？
@Prcuvu Prcuvu added the Bug label Feb 28, 2018
Prcuvu added a commit to Prcuvu/weasel that referenced this issue Feb 28, 2018
@Prcuvu
fix(WeaselUI): limit to subscript range when processing candidates
fc0b5e8 
If candidates.size() is greater than MAX_CANDIDATES_COUNT, only MAX_CANDIDATES_COUNT candidates
are processed to prevent display error.

Fixes rime#121
@Prcuvu Prcuvu closed this as completed in 6b686c7 Feb 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lotem lotem

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lotem @Prcuvu