[Performance] Update a-navigator for optimized memory usage

rh-id · Dec 17, 2021 · 261f46d · 261f46d
1 parent 7791119
commit 261f46d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/app/src/main/java/m/co/rh/id/a_news_provider/app/ui/component/rss/RssItemDetailPage.java b/app/src/main/java/m/co/rh/id/a_news_provider/app/ui/component/rss/RssItemDetailPage.java
@@ -46,11 +46,11 @@ public RssItemDetailPage(RssItem rssItem) {
 
     @Override
     protected View createView(Activity activity, ViewGroup container) {
-        int layoutId = R.layout.page_rss_item_detail;
         if (mSvProvider != null) {
             mSvProvider.dispose();
         }
         mSvProvider = mProvider.get(StatefulViewProvider.class);
+        int layoutId = R.layout.page_rss_item_detail;
         AppSharedPreferences appSharedPreferences = mSvProvider.get(AppSharedPreferences.class);
         if (appSharedPreferences.isOneHandMode()) {
             layoutId = R.layout.one_hand_mode_page_rss_item_detail;
@@ -72,10 +72,10 @@ protected View createView(Activity activity, ViewGroup container) {
         Button fabOpenLink = view.findViewById(R.id.fab_open_link);
         fabOpenLink.setOnClickListener(this);
         if (mRssChannel == null) {
-            RssDao rssDao = mSvProvider.get(RssDao.class);
             mSvProvider.get(RxDisposer.class).add("getRssChannel",
                     Single.fromCallable(() ->
-                            rssDao.findRssChannelById(mRssItem.channelId))
+                            mSvProvider.get(RssDao.class)
+                                    .findRssChannelById(mRssItem.channelId))
                             .subscribeOn(Schedulers.from(mSvProvider.get(ExecutorService.class)))
                             .observeOn(AndroidSchedulers.mainThread())
                             .subscribe((rssChannel, throwable) -> {

diff --git a/base/build.gradle b/base/build.gradle
@@ -41,7 +41,7 @@ dependencies {
 
     api 'com.android.volley:volley:1.2.1'
     api 'com.github.rh-id:a-provider:v0.0.15'
-    api 'com.github.rh-id:a-navigator:v0.0.34'
+    api 'com.github.rh-id:a-navigator:v0.0.37'
     api 'com.github.rh-id:a-logger:v0.0.3'
     testImplementation 'junit:junit:4.13.2'
     androidTestImplementation 'junit:junit:4.13.2'