Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

incorrect uri format #2

Merged
merged 2 commits into from
Jan 9, 2017
Merged

incorrect uri format #2

merged 2 commits into from
Jan 9, 2017

Conversation

andrew-g-za
Copy link
Collaborator

Hi,

I've created a PR to

  • fix the uri format of the test template
  • add a note on where to find the ffasn1dump tool

Please take a look.

@adrianhopebailie
Copy link
Contributor

This change is required but actually still not 100% correct. Based on the defintion of the ni: URI format in RFC6920 there should be 3 slashes /.

3.  Named Information (ni) URI Format

   A Named Information (ni) URI consists of the following nine
   components:

   Scheme Name:  The scheme name is 'ni'.

   Colon and Slashes:  The literal "://"

   Authority:  The optional authority component ...

   One slash:  The literal "/"

   ....

adrianhopebailie
adrianhopebailie requested changes Jan 8, 2017
View reviewed changes
Copy link
Contributor

@adrianhopebailie adrianhopebailie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update to use 3 slashes in ni URLs

@andrew-g-za
Copy link
Collaborator Author

Thanks Adrian,

updated with 6c32091.

@justmoon
Copy link
Contributor

justmoon commented Jan 9, 2017

Please rebase to squash the two commit into one. And please follow our commit message guidelines, i.e. something like fix: ni: URIs should start with three slashes

adrianhopebailie
adrianhopebailie approved these changes Jan 9, 2017
View reviewed changes
Copy link
Contributor

@adrianhopebailie adrianhopebailie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash and merge using commit message guiedlines. I've added you as a collaborator

@andrew-g-za andrew-g-za merged commit c50cba9 into rfcs:master Jan 9, 2017
@andrew-g-za andrew-g-za deleted the fix-uri-format branch January 9, 2017 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianhopebailie adrianhopebailie adrianhopebailie approved these changes

@justmoon justmoon justmoon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrew-g-za @adrianhopebailie @justmoon