Streamline the help view shortcuts with the shortcuts in the menu #9268
+402
−213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
lucasmerlin
added
ui
lucasmerlin
force-pushed
the
lucas/streamline-help-view-shortcuts
branch
from
174ec47 to
0c80752
Compare
|
screenshot plz :) |
|
Mac:
Windows:
There is also snapshot tests for each now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
What
Improves on the new help view, making the shortcuts look more like the shortcuts shown in a menu or command palette.
Also adds scresnshot tests for each help view, since they look pretty different on windows and mac.