-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Infer partition size for FixedSizeList-backed components #9210
Conversation
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
edab458
to
91b7f0d
Compare
Latest documentation preview deployed successfully.
Note: This comment is updated whenever you push a commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pixi.lock change is suspicious, why did it change here?
Cool that this just works :O. But needs a test or snippet using this
Could docs/snippets/all/archetypes/points3d_column_updates.py
be updated for that?
ah the answer is certainly no since inhomogenous partitions sizes can't be detected |
I think this happened because @jleibs updated on a machine with cuda available, and I synced it on my mac? |
Or maybe you're running an old pixi. We just updated #9203 |
I think I'm up to date right? |
4c57a92
to
17a250d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
love the new test, should have had this from the very start when this utility was first introduced
32cac73
to
edaaa50
Compare
b59201e
to
74acbc8
Compare
d98bc0b
to
74c9b4b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
phew, lotsa snippet work. looking great
### Related Closes #9171 ### What This lets the user do: ```py rr.send_columns( "random_3d_points", indexes=[times], columns=rr.Points3D.columns(positions=np.random.random((len(times), 21, 3))), ) ``` --------- Co-authored-by: Andreas Reich <r_andreas2@web.de>
…ys (#9262) ### Related * Follow-up to #9210 ### What In other words, the following snippet broke (which got caught by now-red main ci! phew!) ```py rr.send_columns( "box", indexes=[rr.IndexColumn("tick", sequence=range(1, 101))], columns=rr.Transform3D.columns( translation=[[0, 0, t / 10.0] for t in range(100)], rotation_axis_angle=[ rr.RotationAxisAngle(axis=[0.0, 1.0, 0.0], radians=truncated_radians(t * 4)) for t in range(100) ], ), ) ``` `rotation_axis_angle` worked fine, but `translation` broke because the `columns` call incorrectly assumed that it's 100 columns (correct) each with a batch size of 3 elements (very wrong). * [x] pass full-ci
Related
Closes #9171
What
This lets the user do: