Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shader compilation further in Chrome 131 #9160

Merged
merged 1 commit into from
Mar 3, 2025
Merged

Conversation

yakunouyang
Copy link
Contributor

@yakunouyang yakunouyang commented Feb 27, 2025

Related

What

This pr is extension of #9152, further fixing the shader variable naming issue in Chome 131 version.

Image

after fix:

Image

@abey79 abey79 requested a review from Wumpf March 3, 2025 10:14
@Wumpf Wumpf added 🪳 bug Something isn't working 🕸️ web regarding running the viewer in a browser 💣 crash crash, deadlock/freeze, do-no-start exclude from changelog PRs with this won't show up in CHANGELOG.md labels Mar 3, 2025
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@Wumpf Wumpf added the 🔺 re_renderer affects re_renderer itself label Mar 3, 2025
@Wumpf
Copy link
Member

Wumpf commented Mar 3, 2025

(excluding from changelog since the last pr is included and covers the issue already well enough)

@Wumpf Wumpf merged commit 81e1e0f into rerun-io:main Mar 3, 2025
39 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working 💣 crash crash, deadlock/freeze, do-no-start exclude from changelog PRs with this won't show up in CHANGELOG.md 🔺 re_renderer affects re_renderer itself 🕸️ web regarding running the viewer in a browser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error with webviewer
2 participants