Infer entity paths from LeRobot dataset feature metadata #8981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxkitsune
added
enhancement
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
Wumpf
approved these changes
Feb 10, 2025
| #[derive(Debug, Serialize, Deserialize)] | ||
| #[serde(untagged)] | ||
| pub enum Names { | ||
| Motors { motors: Vec<String> }, |
There was a problem hiding this comment.
It's not just Motors(Vec<String>) to reflect what it looks like in the dataset? Otherwise this looks strangely inconsistent to the List(Vec<_>) below
There was a problem hiding this comment.
Nope, I've seen these two variants:
"names": {
"motors": [
"motor_0",
"motor_1",
"motor_2",
"motor_3",
"motor_4",
"motor_5",
"motor_6",
"motor_7"
]
}or
"names": [
"height",
"width",
"channel"
]There was a problem hiding this comment.
sounds like yes this enum is closely mirroring what shows up in the datasets :)
Closed
oxkitsune
added a commit
that referenced
this pull request
Feb 19, 2025
### Related Closes #8969 ### What We now use the feature metadata from the LeRobot dataset to make the entity paths where possible.  (motor names for both observation and action values when visualizing [lerobot/pusht](https://huggingface.co/datasets/lerobot/pusht))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
Closes #8969
What
We now use the feature metadata from the LeRobot dataset to make the entity paths where possible.
(motor names for both observation and action values when visualizing lerobot/pusht)