Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always split indicators into their own dedicated chunks #8833

Merged
merged 3 commits into from
Jan 28, 2025
Merged

Always split indicators into their own dedicated chunks #8833

merged 3 commits into from
Jan 28, 2025

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Jan 27, 2025 •
edited
Loading

@teh-cmc teh-cmc added ⛃ re_datastore affects the datastore itself 🚀 performance Optimization, memory use, etc exclude from changelog PRs with this won't show up in CHANGELOG.md 🔩 data model Sorbet 🪵 Log & send APIs Affects the user-facing API for all languages labels Jan 27, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 27, 2025 •
edited
Loading

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
✅ 436cd04 https://rerun.io/viewer/pr/8833 +nightly +main

Note: This comment is updated whenever you push a commit.

@teh-cmc
Copy link
Member Author

teh-cmc commented Jan 27, 2025

@rerun-bot full-check

Wumpf
Wumpf approved these changes Jan 27, 2025
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's a lot less involved than I feared it would be, nice

@github-actions GitHub Actions
Copy link

Started a full build: https://github.com/rerun-io/rerun/actions/runs/12995573701

@Wumpf Wumpf mentioned this pull request Jan 27, 2025
Merged
@Wumpf Wumpf merged commit 6ab4951 into main Jan 28, 2025
77 of 78 checks passed
@Wumpf Wumpf deleted the cmc/descriptors_stand_alone branch January 28, 2025 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
🔩 data model Sorbet exclude from changelog PRs with this won't show up in CHANGELOG.md 🪵 Log & send APIs Affects the user-facing API for all languages 🚀 performance Optimization, memory use, etc ⛃ re_datastore affects the datastore itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Log indicators in their own dedicated chunks
2 participants
@teh-cmc @Wumpf