Implement support for opt-in eagerly-serialized archetypes #8646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Web viewer failed to build. | Result | Commit | Link | Manifest | Note: This comment is updated whenever you push a commit. |
teh-cmc
added
🦀 Rust API
emilk
approved these changes
Jan 10, 2025
Comment on lines
+329
to
+333
| let keypoint_ids = arrays_by_descr | ||
| .get(&Self::descriptor_keypoint_ids()) | ||
| .map(|array| { | ||
| SerializedComponentBatch::new(array.clone(), Self::descriptor_keypoint_ids()) | ||
| }); |
There was a problem hiding this comment.
It's so much shorter and beautiful ❤️
zehiko
approved these changes
Jan 13, 2025
teh-cmc
force-pushed
the
cmc/eager_partial_2_tagged_from_to_arrow
branch
from
1ecedd4 to
13926a3
Compare
Base automatically changed from
cmc/eager_partial_2_tagged_from_to_arrow
to
main
January 13, 2025 08:20
teh-cmc
force-pushed
the
cmc/eager_partial_3_eager_archetypes
branch
from
15b27bd to
159b53f
Compare
teh-cmc
force-pushed
the
cmc/eager_partial_3_eager_archetypes
branch
from
7c341c7 to
38330b0
Compare
teh-cmc
added a commit
that referenced
this pull request
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a new
attr.rust.archetype_eagercodegen attribute. When toggled, the associated archetype will now only carry raw Arrow data around, and go through the new eager logging APIs.The attribute has been set on
Points3D:Legacy and eagerly-serialized archetypes can co-exist, making it possible to migrate everything incrementally.
Archetype::{from_arrow, to_arrow}and friends tag compliant #8644