-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always log all components of Transform3D
#7111
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployed docs
|
d1f6f5e
to
5a464b4
Compare
5a464b4
to
c19457d
Compare
Wumpf
approved these changes
Aug 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great sample improvements. lgtm minus typos
crates/store/re_types/definitions/rerun/archetypes/leaf_transforms3d.fbs
Outdated
Show resolved
Hide resolved
crates/store/re_types/definitions/rerun/archetypes/transform3d.fbs
Outdated
Show resolved
Hide resolved
Co-authored-by: Andreas Reich <andreas@rerun.io>
Co-authored-by: Andreas Reich <andreas@rerun.io>
Co-authored-by: Andreas Reich <andreas@rerun.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Best reviewed ignoring whitespace changes.
The serializers for
Transform3D
andLeafTransform3D
will now always write every component, effectively clearing all previously logged values.Transform3D
usesOption<C>
for each component, treating it as a single-element list component list whereNone
is empty. If we ever want to support updating some components using the transform (as outlined in #3381) we would need to turn this into a tristate, i.e. something likeNoneOrZeroOrOne<C>
.LeafTransform3D
usesOption<Vec<C>>
for its components, but has no interface yet for logging an update.Both
Transform3D
andLeafTransform3D
has a new::clear()
constructor in Rust, that replaced both::new()
and::default()
. This is for added clarity, and to make the transition easier if we ever add an::update()
constructor, as per #3381Checklist
main
build: rerun.io/viewernightly
build: rerun.io/viewerCHANGELOG.md
and the migration guideTo run all checks from
main
, comment on the PR with@rerun-bot full-check
.