Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always log all components of Transform3D #7111

Merged
merged 23 commits into from
Aug 9, 2024

Conversation

emilk
Copy link
Member

@emilk emilk commented Aug 8, 2024

What

Best reviewed ignoring whitespace changes.

The serializers for Transform3D and LeafTransform3D will now always write every component, effectively clearing all previously logged values.

Transform3D uses Option<C> for each component, treating it as a single-element list component list where None is empty. If we ever want to support updating some components using the transform (as outlined in #3381) we would need to turn this into a tristate, i.e. something like NoneOrZeroOrOne<C>.

LeafTransform3D uses Option<Vec<C>> for its components, but has no interface yet for logging an update.

Both Transform3D and LeafTransform3D has a new ::clear() constructor in Rust, that replaced both ::new() and ::default(). This is for added clarity, and to make the transition easier if we ever add an ::update() constructor, as per #3381

image

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@emilk emilk added the 🔩 data model Sorbet label Aug 8, 2024
Copy link

github-actions bot commented Aug 8, 2024

Deployed docs

Commit Link
e4f6b37 https://landing-n1nv1i4zl-rerun.vercel.app/docs

@emilk emilk added the exclude from changelog PRs with this won't show up in CHANGELOG.md label Aug 8, 2024
@emilk emilk force-pushed the emilk/transform-logs-all-components branch 2 times, most recently from d1f6f5e to 5a464b4 Compare August 8, 2024 13:20
@emilk emilk marked this pull request as ready for review August 8, 2024 13:27
@emilk emilk force-pushed the emilk/transform-logs-all-components branch from 5a464b4 to c19457d Compare August 8, 2024 14:18
@Wumpf Wumpf self-requested a review August 8, 2024 16:28
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great sample improvements. lgtm minus typos

emilk and others added 3 commits August 9, 2024 10:54
Co-authored-by: Andreas Reich <andreas@rerun.io>
Co-authored-by: Andreas Reich <andreas@rerun.io>
Co-authored-by: Andreas Reich <andreas@rerun.io>
@emilk emilk merged commit 3f369e0 into main Aug 9, 2024
40 checks passed
@emilk emilk deleted the emilk/transform-logs-all-components branch August 9, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔩 data model Sorbet exclude from changelog PRs with this won't show up in CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Transform3D always log all its components
2 participants