Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple change to make our encoding methods take iterators of results instead of iterators of unwrapped values.
In most (all?) real-world scenarios, you will have to deal with errors as you serialize
LogMsg
s.The previous design forced you to collect all that data in order to first check for errors, and only then start encoding. Now you can just stream as needed.
In the rare case where nothing can fail, you're just one
.map(Ok)
away anyway.As a side-effect,
rerun rrd merge|compact
now streams their output.Checklist
main
build: rerun.io/viewernightly
build: rerun.io/viewerCHANGELOG.md
and the migration guideTo run all checks from
main
, comment on the PR with@rerun-bot full-check
.