Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the UI colors to use our (blueish) ramp instead of pure greys #7075

Merged
merged 6 commits into from
Aug 8, 2024

Conversation

abey79
Copy link
Member

@abey79 abey79 commented Aug 6, 2024

What

This PR changes most shades of grey used in the UI to those defined in the design token color ramp, which has a slight blueish taint. This reduces a lot of cold/warm contrast we used to have, for a more uniform look.

Before:

image

After:

image

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@abey79 abey79 added ui concerns graphical user interface include in changelog labels Aug 6, 2024
@abey79 abey79 requested a review from gavrelina August 6, 2024 13:38
@abey79
Copy link
Member Author

abey79 commented Aug 6, 2024

@gavrelina

Tab bar title color is currently 175.
Bottom bar color is currently 150.

Bottom bar stroke color was pure grey(47) but I just changed it to 250, like separators. Its this one:
image

We need to fix tooltip background as well. Currently it's grey(35):

image

The top bar is grey(20). I assume it should be changed too.
image

@gavrelina
Copy link
Member

@abey79 so following up your comment above, a few changes:

  1. "Tab bar title color is currently 175." => change to 200
  2. "Bottom bar color is currently 150." => double checking — you mean the bar of the timeline section, right? and with it the most of the timeline panel as well. We leave it as is! because we are imitating a bit of the depth with elevating the bottom part of the UI.
  3. "tooltip grey(35)" => to 250 (it's lighter than most of our backgrounds, because we want a tooltip to have a feeling of elevation as well!). This also shall be apply for the Rerun menu background color.
    3a. There is a grey entity on hover (in my screenshot it has old grey, in your screenshot I see you have changed that already) => to double check it, should be 325
Screenshot 2024-08-07 at 14 10 47
  1. "The top bar is grey(20)" => it has some funky alignments, let's remove the extra grey shade from it, keep it 100 or actually use Alias.Color.Surface.Default.value.

  2. There is also a hover on the tabs and/or rr logo that is grey. Change it to 325 (like 3a). I mean these:

Screenshot 2024-08-07 at 14 19 43

@abey79
Copy link
Member Author

abey79 commented Aug 8, 2024

Updated as per your comment—looks much nicer!

you mean the bar of the timeline section, right?

Yes!

@abey79 abey79 marked this pull request as ready for review August 8, 2024 10:19
Copy link
Member

@gavrelina gavrelina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So nice!

@abey79 abey79 merged commit 820313b into main Aug 8, 2024
34 checks passed
@abey79 abey79 deleted the antoine/fix-color-scheme branch August 8, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include in changelog ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants