Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash on shutdown when using global recording stream variables in C++ #7063

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Aug 5, 2024

What

Was able to repro this on Mac but not on Windows. Fix is a bit wonky but worked reliably for me. Details see code comments!

Checklist

  • confirm this fixes things on Linux -> adjourned to when we have a new dev release
  • confirm this doesn't cause new issues on Windows
  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@Wumpf Wumpf added 🪳 bug Something isn't working 💣 crash crash, deadlock/freeze, do-no-start 🌊 C++ API C/C++ API specific include in changelog labels Aug 5, 2024
@Wumpf Wumpf force-pushed the andreas/cpp/fix-global-recording-stream branch from 4c89a68 to 09dc07d Compare August 5, 2024 16:54
@Wumpf Wumpf changed the title Fix crash on shutdown when using global recording stream variables Fix crash on shutdown when using global recording stream variables in C++ Aug 5, 2024
@Wumpf Wumpf force-pushed the andreas/cpp/fix-global-recording-stream branch 3 times, most recently from ba2bed8 to e9e87ce Compare August 5, 2024 16:57
@Wumpf Wumpf force-pushed the andreas/cpp/fix-global-recording-stream branch from e9e87ce to dd3ffc4 Compare August 5, 2024 16:59
@Wumpf Wumpf merged commit 99c20b3 into main Aug 6, 2024
38 of 40 checks passed
@Wumpf Wumpf deleted the andreas/cpp/fix-global-recording-stream branch August 6, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working 🌊 C++ API C/C++ API specific 💣 crash crash, deadlock/freeze, do-no-start include in changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

C++ SDK crash on shutdown
2 participants