Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chunkify everything left #7032

Merged
merged 12 commits into from
Aug 2, 2024
Merged

Chunkify everything left #7032

merged 12 commits into from
Aug 2, 2024

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Aug 1, 2024 •
edited by github-actions bot
Loading

Chunkify all the spread out little things that are left all over the place.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@teh-cmc teh-cmc added 📺 re_viewer affects re_viewer itself 🔍 re_query affects re_query itself 🚀 performance Optimization, memory use, etc do-not-merge Do not merge this PR include in changelog labels Aug 1, 2024
@teh-cmc teh-cmc mentioned this pull request Aug 1, 2024
Merged
6 tasks
@Wumpf Wumpf self-requested a review August 2, 2024 08:08
@teh-cmc teh-cmc force-pushed the cmc/chunkified_queries_16_text_log branch from dd8f5b3 to 3137c4a Compare August 2, 2024 10:02
Base automatically changed from cmc/chunkified_queries_16_text_log to main August 2, 2024 10:02
@teh-cmc teh-cmc force-pushed the cmc/chunkified_queries_17_everything_else branch from 3b84331 to 3298ae1 Compare August 2, 2024 10:08
@teh-cmc teh-cmc removed the do-not-merge Do not merge this PR label Aug 2, 2024
@teh-cmc teh-cmc merged commit bf47c42 into main Aug 2, 2024
21 of 23 checks passed
@teh-cmc teh-cmc deleted the cmc/chunkified_queries_17_everything_else branch August 2, 2024 10:09
teh-cmc added a commit that referenced this pull request Aug 2, 2024
@teh-cmc
Remove legacy query engine and promises (#7033)
4d61b04 
Everything has been chunkified. Remove `re_query`, remove promises.

- Fixes #6813
- Fixes #6814
- Fixes #4810
- Fixes #5607
- DNM: requires #7032
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
include in changelog 🚀 performance Optimization, memory use, etc 🔍 re_query affects re_query itself 📺 re_viewer affects re_viewer itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teh-cmc @Wumpf