Chunkified, deserialization-free visualizers for all standard shapes #7020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teh-cmc
added
📺 re_viewer
This was referenced Jul 31, 2024
Wumpf
approved these changes
Aug 1, 2024
| @@ -10,7 +10,8 @@ namespace rerun.components; | |||
| /// The box extends both in negative and positive direction along each axis. | |||
| /// Negative sizes indicate that the box is flipped along the respective axis, but this has no effect on how it is displayed. | |||
| struct HalfSize3D ( | |||
| "attr.rust.derive": "Copy, PartialEq" | |||
| "attr.rust.derive": "Copy, PartialEq, bytemuck::Pod, bytemuck::Zeroable", | |||
| "attr.rust.repr": "transparent" | |||
There was a problem hiding this comment.
huh actually all components should be transparent now, right?
Comment on lines
282
to
283
| // TODO(#6831): we have to deserialize here because `Rotation3D` is still a complex | ||
| // type at this point. |
teh-cmc
force-pushed
the
cmc/chunkified_queries_13_ellipsoid3d
branch
from
02dec9c to
a12f475
Compare
teh-cmc
force-pushed
the
cmc/chunkified_queries_14_remaining_shapes
branch
from
13bcc8d to
bf6a7d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chunkified, (mostly)deserialization-free visualizers for all remaining standard shapes.
Pretty straightforward now that we have all the iteration tools already in place.
Ellipsoidsrenamed toEllipsoids3D#7019Ellipsoids3D
Boxes2D
Boxes3D
Arrows2D
Arrows3D
Checklist
mainbuild: rerun.io/viewernightlybuild: rerun.io/viewerCHANGELOG.mdand the migration guideTo run all checks from
main, comment on the PR with@rerun-bot full-check.