Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rerun rrd compact: always put blueprints at the start of the recordings #6998

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Jul 25, 2024

Slight modification to rerun rrd compact in order to make sure that, if the recording contains one or more blueprints, they end up at the beginning of it, otherwise the experience would suck since the blueprint would only get loaded once all the data had finished streaming in.

cc @jleibs

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@teh-cmc teh-cmc added 🧑‍💻 dev experience developer experience (excluding CI) do-not-merge Do not merge this PR 🟦 blueprint The data that defines our UI include in changelog CLI Related to the Rerun CLI labels Jul 25, 2024
@teh-cmc teh-cmc changed the title TODO 8: todo rerun rrd compact: always put blueprints at the start of the recordings Jul 25, 2024
@teh-cmc teh-cmc marked this pull request as ready for review July 25, 2024 16:57
@teh-cmc teh-cmc mentioned this pull request Jul 25, 2024
6 tasks
@teh-cmc teh-cmc force-pushed the cmc/chunkified_queries_7_transformables branch from 9f763a3 to 23e7ee1 Compare July 29, 2024 12:46
@teh-cmc teh-cmc force-pushed the cmc/chunkified_queries_8_sort_rbl_first branch from 53f4bc6 to 0fd7264 Compare July 29, 2024 12:47
@teh-cmc teh-cmc force-pushed the cmc/chunkified_queries_7_transformables branch from 23e7ee1 to fc1498e Compare July 29, 2024 16:07
Base automatically changed from cmc/chunkified_queries_7_transformables to main July 29, 2024 16:08
@teh-cmc teh-cmc force-pushed the cmc/chunkified_queries_8_sort_rbl_first branch from 0fd7264 to f2ddfb5 Compare July 29, 2024 16:09
@teh-cmc teh-cmc removed the do-not-merge Do not merge this PR label Jul 29, 2024
@teh-cmc teh-cmc merged commit 4aff4fa into main Jul 29, 2024
24 of 29 checks passed
@teh-cmc teh-cmc deleted the cmc/chunkified_queries_8_sort_rbl_first branch July 29, 2024 16:09
@teh-cmc teh-cmc added the 🪳 bug Something isn't working label Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🟦 blueprint The data that defines our UI 🪳 bug Something isn't working CLI Related to the Rerun CLI 🧑‍💻 dev experience developer experience (excluding CI) include in changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants