Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate new data APIs with EntityDb/UI/Blueprint things #6994

Merged
merged 11 commits into from
Jul 29, 2024

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Jul 25, 2024

Integrate the new data APIs in EntityDb and propagate the changes in all the different blueprint/UI related code paths.

In particular, this ports all the code related to HybridResults / blueprint overrides and such, which we're going to need very soon in order to port the time series view.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@teh-cmc teh-cmc changed the title TODO 4: todo Expose new data APIs to UI and blueprint-y things Jul 25, 2024
@teh-cmc teh-cmc changed the title Expose new data APIs to UI and blueprint-y things Integrate new data APIs with EntityDb/UI/Blueprint things Jul 25, 2024
@teh-cmc teh-cmc added 📺 re_viewer affects re_viewer itself 🔍 re_query affects re_query itself do-not-merge Do not merge this PR include in changelog labels Jul 25, 2024
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty much exactly the same as the old one, except made to work with Chunks.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty much exactly the same as the old one, except made to work with Chunks.

@teh-cmc teh-cmc mentioned this pull request Jul 25, 2024
6 tasks
@teh-cmc teh-cmc marked this pull request as ready for review July 26, 2024 14:09
@Wumpf Wumpf self-requested a review July 29, 2024 11:13
@teh-cmc teh-cmc force-pushed the cmc/chunkified_queries_3_new_range branch from 0c0bcbb to ef2892c Compare July 29, 2024 11:17
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (didn't look super thoroughly, but nothing worth commenting hit me scrolling through stuff)

less weird resolver passing <3

Base automatically changed from cmc/chunkified_queries_3_new_range to main July 29, 2024 12:33
@teh-cmc teh-cmc force-pushed the cmc/chunkified_queries_4_entitydb_integration branch from 8352397 to d1331a4 Compare July 29, 2024 12:33
@teh-cmc teh-cmc removed the do-not-merge Do not merge this PR label Jul 29, 2024
@teh-cmc teh-cmc merged commit c240d8e into main Jul 29, 2024
24 of 29 checks passed
@teh-cmc teh-cmc deleted the cmc/chunkified_queries_4_entitydb_integration branch July 29, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include in changelog 🔍 re_query affects re_query itself 📺 re_viewer affects re_viewer itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants