-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate new data APIs with EntityDb/UI/Blueprint things #6994
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty much exactly the same as the old one, except made to work with Chunk
s.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty much exactly the same as the old one, except made to work with Chunk
s.
0c0bcbb
to
ef2892c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm (didn't look super thoroughly, but nothing worth commenting hit me scrolling through stuff)
less weird resolver passing <3
…s (basically forked)
8352397
to
d1331a4
Compare
Integrate the new data APIs in
EntityDb
and propagate the changes in all the different blueprint/UI related code paths.In particular, this ports all the code related to
HybridResults
/ blueprint overrides and such, which we're going to need very soon in order to port the time series view.Checklist
main
build: rerun.io/viewernightly
build: rerun.io/viewerCHANGELOG.md
and the migration guideTo run all checks from
main
, comment on the PR with@rerun-bot full-check
.