Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic checklist to test different 3D transform types & transform hierarchy propagation #6968

Merged
merged 3 commits into from
Jul 24, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Jul 23, 2024

What

Needs these to work properly:

image

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@Wumpf Wumpf added 🔨 testing testing and benchmarks include in changelog labels Jul 23, 2024
@teh-cmc teh-cmc self-requested a review July 24, 2024 06:54
@teh-cmc teh-cmc force-pushed the andreas/transform3d-hierarchy-checklist branch from 45a351f to 56a1657 Compare July 24, 2024 07:01
@Wumpf
Copy link
Member Author

Wumpf commented Jul 24, 2024

thanks for rebasing!

@Wumpf Wumpf merged commit 0f0bf23 into main Jul 24, 2024
35 checks passed
@Wumpf Wumpf deleted the andreas/transform3d-hierarchy-checklist branch July 24, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants