-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite Image
archetype
#6942
Merged
Merged
Rewrite Image
archetype
#6942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Deployed docs
|
@rerun-bot full-check |
Started a full build: https://github.com/rerun-io/rerun/actions/runs/10007215353 |
Wumpf
reviewed
Aug 1, 2024
Wumpf
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Breaking changes
Image(…).compress(…)
is nowImageEncoded.compres(…)
ImageEncoded
has very different constructor compared to 0.17, and only supports chroma-downsampled imagesTODO
rerun/rerun_py/rerun_sdk/rerun/archetypes/image_encoded_ext.py
Lines 150 to 157 in 8974966
rerun/rerun_py/tests/unit/test_image.py
Lines 16 to 45 in 4f12d7f
detect_and_track_objects
[ ] Log a warning ifcolor_model
is missing, so that we can in the future migrate to having BGR be the default[ ] Consider re-implementingimage.compress(…)
(with a forward call toImageEncoded.compress
Checklist
main
build: rerun.io/viewernightly
build: rerun.io/viewerCHANGELOG.md
and the migration guide:To run all checks from
main
, comment on the PR with@rerun-bot full-check
.