Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll dataframe view to focused item #6908

Merged
merged 2 commits into from
Jul 16, 2024
Merged

Conversation

abey79
Copy link
Member

@abey79 abey79 commented Jul 16, 2024

What

This PR scrolls the dataframe view to the focused entity/instance.

This would be further enhanced by addressing:

dataframe_scroll_focus.mp4

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@abey79 abey79 added enhancement New feature or request ui concerns graphical user interface include in changelog labels Jul 16, 2024
@Wumpf Wumpf self-requested a review July 16, 2024 13:14
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat

Comment on lines +24 to +26
//
// DATA
//
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: if the separation is important to you, why don't you make it several functions? :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Short answer, because of the tight coupling these functions would have, implying tuple return values and loads of parameters. I feel this would be strictly worse for such cases (aka. a "mono-function" file with that very "sequential" nature to it).

I'm not super happy with the status quo either. I wish rustfmt would let me insert an additional newline or two between "sections". Could go with the "// ================"-style comment, but I'm more used to have them between functions.

Arf.. life is though.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gonna merge as is. This code is likely to be rewritten 3 times in the next couple of months anyways :)

@abey79 abey79 merged commit e904513 into main Jul 16, 2024
34 of 35 checks passed
@abey79 abey79 deleted the antoine/dataframe-scroll-to-focus branch July 16, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request include in changelog ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants