Remove TensorBuffer::JPEG, DecodedTensor, TensorDecodeCache
#6884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployed docs
|
emilk
force-pushed
the
emilk/remove-old-jpeg
branch
from
f992894 to
86547fb
Compare
This was referenced Jul 14, 2024
emilk
changed the title
TensorBuffer::JPEG, DecodedTensor, TensorDecodeCacheTensorBuffer::JPEG, DecodedTensor, TensorDecodeCache
Wumpf
approved these changes
Jul 15, 2024
| @@ -393,19 +377,13 @@ pub fn tensor_summary_ui_grid_contents( | |||
| | TensorBuffer::F16(_) | |||
| | TensorBuffer::F32(_) | |||
| | TensorBuffer::F64(_) => {} | |||
| TensorBuffer::Jpeg(jpeg_bytes) => { | |||
There was a problem hiding this comment.
this makes me realize that there's no custom data ui for EncodedImage yet unless I missed a blob of code along the way.
Needs to be put on the todo list!
Edit: Ah this is a much deeper problem obviously. There's no EncodedImage component, so this whole line of work makes us loose the ability to see images in the property view. We may want to come up with something new here short or long term. Worth discussing today or later this week :)
emilk
added a commit
that referenced
this pull request
Jul 15, 2024
### What * Part of #6844 * Next PR: #6874 * Next +1: #6883 (where we rename it to `ImageChromaDownsampled`) * Next +2: #6884 This is a temporary measure to make room for a new `archetypes.ImageEncoded` without name collision. I plan to remove `ImageEncodedHelper` fully before 0.18. `ImageEncodedHelper` handles both image files (JPEG, PNG, …) and chroma sub-sampled data (NV12, YUY2). In the new design, the former will be handled by `ImageEncoded`, but chroma-subsampled images will be stored directly as `Image`s, with a special `PixelFormat`. This means that once 0.18 is done, only users using chroma subsampling will have to update their code. I'll make sure the new `ImageEncoded` archetype ctor supports all of the same parameters as the old helper, so that there are helpful runtime error messages for our users. ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/6882?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/6882?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! * [x] If have noted any breaking changes to the log API in `CHANGELOG.md` and the migration guide - [PR Build Summary](https://build.rerun.io/pr/6882) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) To run all checks from `main`, comment on the PR with `@rerun-bot full-check`.
emilk
added a commit
that referenced
this pull request
Jul 15, 2024
) ### What * Part of #6844 * Part of #3803 Has `do-no-merge` because of current merge-target. ### PR train * Prev: #6882 * Next: #6883 * Next: #6884 ### Coming in follow-up PRs: * Fix image picking, hovering, and visualization in spatial view * Switch to using `ImageEncoded` in all examples * Remove old code for storing JPEGs in tensors ### Fixes * Fixes #6520 ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/6874?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/6874?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! * [x] If have noted any breaking changes to the log API in `CHANGELOG.md` and the migration guide - [PR Build Summary](https://build.rerun.io/pr/6874) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) To run all checks from `main`, comment on the PR with `@rerun-bot full-check`. --------- Co-authored-by: Andreas Reich <andreas@rerun.io>
emilk
force-pushed
the
emilk/use-image-encoded
branch
from
209e0d2 to
b54fbbd
Compare
emilk
added a commit
that referenced
this pull request
Jul 15, 2024
### What * Part of #6844 * Closes #3803 This switches us to use the new `archetype.ImageEncoded` in all examples. Logging chroma-downsampled images (NV12/YUY2) is now done with the new `ImageChromaDownsampled` helper (which will probably go away before 0.18). ### PR train * Prev: #6882 * Prev: #6874 * Next: #6884 ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [ ] I have tested the web demo (if applicable): * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/6883?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/6883?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! * [x] If have noted any breaking changes to the log API in `CHANGELOG.md` and the migration guide - [PR Build Summary](https://build.rerun.io/pr/6883) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) To run all checks from `main`, comment on the PR with `@rerun-bot full-check`.
An error occurred while trying to automatically change base from
emilk/use-image-encoded
to
main
July 15, 2024 10:12
emilk
force-pushed
the
emilk/remove-old-jpeg
branch
from
be70c25 to
7a7eb05
Compare
|
@rerun-bot full-check |
|
Started a full build: https://github.com/rerun-io/rerun/actions/runs/9937925485 |
teh-cmc
changed the title
TensorBuffer::JPEG, DecodedTensor, TensorDecodeCacheTensorBuffer::JPEG, DecodedTensor, TensorDecodeCache
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TensorBuffer::JPEGwithImageEncodedarchetype #3803JPEG-encoded RRDsRust API
TensorBuffer::JPEGTensorData::from_jpeg_bytesImage::from_file_pathandfrom_file_contentsFor all of these, use
ImageEncodedinstead.PR train
ImageEncodedtoImageEncodedHelper#6882archetypes.ImageEncodedwith PNG and JPEG support #6874ImageChromaDownsampled#6883Checklist
mainbuild: rerun.io/viewernightlybuild: rerun.io/viewerCHANGELOG.mdand the migration guideTo run all checks from
main, comment on the PR with@rerun-bot full-check.