Optimize data clamping in spatial view #6870
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
We do a lot of "clamped joins", where the last element of a component is repeated to match the number of instances.
The code for this was neither ergonomic, nor performant. Now it should be better at both.
In particular, complex iterators like
.chain(…).take(…)
are often slow and difficult for the optimizer to see through.Read the commit messages!
This shaves off another 0.5-1 ms off of OPF, out of ~4ms for the inner
Points3D
visualizer.Checklist
main
build: rerun.io/viewernightly
build: rerun.io/viewerCHANGELOG.md
and the migration guideTo run all checks from
main
, comment on the PR with@rerun-bot full-check
.