Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete unused methods from DataResult and make PropertyOverrides non-optional #6809

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Jul 8, 2024

What

The latter has been a big annoyance for quite a while. No more!

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

Wumpf and others added 2 commits July 8, 2024 14:48
@Wumpf Wumpf added 🚜 refactor Change the code, not the functionality exclude from changelog PRs with this won't show up in CHANGELOG.md labels Jul 8, 2024
@Wumpf Wumpf requested a review from jleibs July 8, 2024 12:52
@Wumpf Wumpf merged commit d38d376 into main Jul 9, 2024
36 of 37 checks passed
@Wumpf Wumpf deleted the andreas/view-query-improvements branch July 9, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md 🚜 refactor Change the code, not the functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants