Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize large point clouds #6767

Merged
merged 4 commits into from
Jul 4, 2024
Merged

Optimize large point clouds #6767

merged 4 commits into from
Jul 4, 2024

Conversation

emilk
Copy link
Member

@emilk emilk commented Jul 4, 2024

What

This saves us a lot of time, with less code :)

Basically: if we have colors for all our points, then we can ignore the annotation contexts. Before we ignored them once for each point, now we ignore them all in one go.

I also added a happy path for position/radii

opf before

Screenshot 2024-07-04 at 15 19 19

opf after

Screenshot 2024-07-04 at 15 20 23

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

@emilk emilk changed the title Optimize color collection, e.g. for large point clouds Optimize large point clouds Jul 4, 2024
@emilk emilk added 🚀 performance Optimization, memory use, etc include in changelog labels Jul 4, 2024
@emilk emilk added this to the 0.17 milestone Jul 4, 2024
@Wumpf Wumpf self-requested a review July 4, 2024 14:28
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice :chefkiss:

@Wumpf Wumpf merged commit 8bc043d into main Jul 4, 2024
34 checks passed
@Wumpf Wumpf deleted the emilk/optimize-colors branch July 4, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include in changelog 🚀 performance Optimization, memory use, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants