Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix snippet CI #6715

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Fix snippet CI #6715

merged 1 commit into from
Jul 2, 2024

Conversation

abey79
Copy link
Member

@abey79 abey79 commented Jul 2, 2024 •
edited by teh-cmc
Loading

What

Fix CI breakage introduced by #6679

  •   full CI passes

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

@abey79 abey79 added 🪳 bug Something isn't working exclude from changelog PRs with this won't show up in CHANGELOG.md 🚢 CI labels Jul 2, 2024
@abey79
Copy link
Member Author

abey79 commented Jul 2, 2024

@rerun-bot full

@Wumpf Wumpf self-requested a review July 2, 2024 12:04
Wumpf
Wumpf approved these changes Jul 2, 2024
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm if passes

@abey79
Copy link
Member Author

abey79 commented Jul 2, 2024

@rerun-bot full-check

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 2, 2024

Started a full build: https://github.com/rerun-io/rerun/actions/runs/9760744543

@teh-cmc
Copy link
Member

teh-cmc commented Jul 2, 2024

image

@teh-cmc teh-cmc merged commit f1d7405 into main Jul 2, 2024
70 of 72 checks passed
@teh-cmc teh-cmc deleted the antoine/fix-ci-snippet branch July 2, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
🪳 bug Something isn't working exclude from changelog PRs with this won't show up in CHANGELOG.md 🚢 CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abey79 @teh-cmc @Wumpf