Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve container selection panel UI #6711

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

abey79
Copy link
Member

@abey79 abey79 commented Jul 2, 2024

What

This PR fixes the spacing regression and generally cleans up the Container selection panel UI using list item and the section_collapsing_header. The buttons are implemented using list item as well, which is far from ideal -> #6707

image

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

@abey79 abey79 added 🪳 bug Something isn't working enhancement New feature or request ui concerns graphical user interface include in changelog labels Jul 2, 2024
@Wumpf Wumpf self-requested a review July 2, 2024 10:06
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! nothing that can't be solved with listitem 😄

@Wumpf Wumpf merged commit 4b5bffd into main Jul 2, 2024
34 checks passed
@Wumpf Wumpf deleted the antoine/improve-container-selection-panel branch July 2, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working enhancement New feature or request include in changelog ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Container selection panel UI has bad spacing
2 participants