Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move entity filter "edit" button to a section header icon #6662

Merged
merged 4 commits into from
Jun 27, 2024
Merged

Move entity filter "edit" button to a section header icon #6662

merged 4 commits into from
Jun 27, 2024

Conversation

abey79
Copy link
Member

@abey79 abey79 commented Jun 27, 2024 •
edited
Loading

What

This PR is mainly a refactor that abstract the buttons used by PropertyContent and SectionCollapsingHeader. (This refactor is partial and should also be applied to LabelContent -> #6191).

This enables action button in section header, used to remove the "edit" button of the entity filter:
image

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

@abey79 abey79 added enhancement New feature or request ui concerns graphical user interface 🚜 refactor Change the code, not the functionality include in changelog labels Jun 27, 2024
Base automatically changed from antoine/collapsing-header-refactor to main June 27, 2024 12:24
@abey79 abey79 force-pushed the antoine/refactor-item-button branch from 91aa7ef to b09294e Compare June 27, 2024 12:25
@abey79 abey79 mentioned this pull request Jun 27, 2024
Closed
7 tasks
@Wumpf Wumpf self-requested a review June 27, 2024 15:36
Wumpf
Wumpf approved these changes Jun 27, 2024
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so pretty! both the ui and the code improvement of having an ItemButton concept

crates/re_ui/src/section_collapsing_header.rs
use crate::{list_item, DesignTokens, Icon, UiExt as _};

/// Icon button to be used in the header of a panel.
pub struct HeaderMenuButton<'a> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't I review this being moved just a few hours ago 😄

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That pesky thing had a short—but intense—life :)

@abey79 abey79 merged commit 3178dd5 into main Jun 27, 2024
33 of 34 checks passed
@abey79 abey79 deleted the antoine/refactor-item-button branch June 27, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request include in changelog 🚜 refactor Change the code, not the functionality ui concerns graphical user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abey79 @Wumpf