Allow streaming to the viewer from the cell where it's created #6640
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Previously the viewer would not be initialized until the end of cell execution, creating an awkward 2-step process.
Some notes in the anywidget discord got me enough info to hypothesize that something like https://github.com/Kirill888/jupyter-ui-poll might exist... and it works!
By default
Viewer.display
will now call the new helper that blocks until initialization is complete.I also decided that
display=True
on the widget constructor was a little bit odd and changed this to just useViewer.display()
.Checklist
main
build: rerun.io/viewernightly
build: rerun.io/viewerTo run all checks from
main
, comment on the PR with@rerun-bot full-check
.