-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganize Selection Panel #6637
Conversation
consensus so far (and what's noted down in the ticket) was to push visible/interactive all the way up to the top without its own section https://rerunio.slack.com/archives/C041NHU952S/p1718878768702219?thread_ts=1718822157.478409&cid=C041NHU952S |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
skimmed the code mostly only, lgtm. Above comments need addressing but doesn't need to be in here (need to note it down though if we don't do it right away)
…ngHeader` using `re_ui::ListItem` (#6657) ### What - Follow-up to #6637 - Part of #6655 This PR completely rewrites the existing `large_collapsing_header` stuff as follows: - Renamed `SectionCollapsingHeader`. - Now a struct with builder pattern, can be created with convenience `ui.section_collapsing_header("label")`. - Supports menu button - Support help tooltip - Added `ListItem::show_hierarchical_with_children_unindented`. Note: the label must now be double-clicked to collapse/uncollapse, as per `ListItem` behaviour. Few visible changes beyond the help tooltip. The background no longer changes on hover. <img width="431" alt="image" src="https://github.com/rerun-io/rerun/assets/49431240/20be7205-59a3-40a7-9692-c9c2a89ea0b6"> ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/6657?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/6657?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! - [PR Build Summary](https://build.rerun.io/pr/6657) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) To run all checks from `main`, comment on the PR with `@rerun-bot full-check`.
What
Each section now only does one thing, with a good name to describe it, and in a good order.
Checklist
main
build: rerun.io/viewernightly
build: rerun.io/viewerTo run all checks from
main
, comment on the PR with@rerun-bot full-check
.