Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize Selection Panel #6637

Merged
merged 39 commits into from
Jun 26, 2024
Merged

Reorganize Selection Panel #6637

merged 39 commits into from
Jun 26, 2024

Conversation

emilk
Copy link
Member

@emilk emilk commented Jun 25, 2024

What

Each section now only does one thing, with a good name to describe it, and in a good order.

image image

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

@emilk emilk added ui concerns graphical user interface include in changelog labels Jun 25, 2024
@emilk emilk marked this pull request as draft June 25, 2024 13:13
@Wumpf
Copy link
Member

Wumpf commented Jun 25, 2024

consensus so far (and what's noted down in the ticket) was to push visible/interactive all the way up to the top without its own section https://rerunio.slack.com/archives/C041NHU952S/p1718878768702219?thread_ts=1718822157.478409&cid=C041NHU952S
personally I think its own section is also fine, but Entity properties is not the right name for it. All of these things are properties of the selected entity

@Wumpf
Copy link
Member

Wumpf commented Jun 25, 2024

View settings also makes me pause a bit: we called it View properties so far, but maybe settings is actually better. But then we also have to change it in the docs, e.g. here https://rerun.io/docs/reference/types/views/spatial3d_view#properties

@emilk emilk marked this pull request as ready for review June 25, 2024 15:13
@Wumpf Wumpf self-requested a review June 26, 2024 07:28
@Wumpf
Copy link
Member

Wumpf commented Jun 26, 2024

The separation line at the end of visible time range doesn't make sense to me. Is this a left over or intentional?
image

@Wumpf
Copy link
Member

Wumpf commented Jun 26, 2024

interesting bug: the arrows are not aligned
image
Likely unrelated to this PR

@Wumpf
Copy link
Member

Wumpf commented Jun 26, 2024

This tooltip isn't pretty being elongated as it is
image

Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

skimmed the code mostly only, lgtm. Above comments need addressing but doesn't need to be in here (need to note it down though if we don't do it right away)

@abey79
Copy link
Member

abey79 commented Jun 26, 2024

I'm seeing some issues with that header:

  1. it should force align itself on round pixels vertically, to avoid that thin gap
  2. alignment bug with the + button
  3. Hot take: its background should not become brighter on hover. The white text + the triangle is enough of an indication that it can be interacted with. This would much improve the hover behaviour of the + button too.

Both of these would be addressed by implementing it using listitem, but doing so would force an indent on the expended content (unless we add an indent-less version of show_* to list item).

Also, the final horizontal separator after Visible Time Range should be removed.

image

edit: here is how it's done with list item:

image

@abey79
Copy link
Member

abey79 commented Jun 26, 2024

I'm not fully convinced by the new placement of the ?/Edit button here:

image

Ideally we'd have an "Edit" icon and something like this:

image

having the "?" up there would be useful in other places, such as the visualiser section.

@abey79
Copy link
Member

abey79 commented Jun 26, 2024

There vertical spacing is still a bit all over the place. In this data section, the fact that the list items hover-highlight further show that there is a gap.

image
image

@abey79 abey79 mentioned this pull request Jun 26, 2024
7 tasks
@abey79 abey79 merged commit fd32e50 into main Jun 26, 2024
34 checks passed
@abey79 abey79 deleted the emilk/reorganize-selection-panel branch June 26, 2024 13:23
abey79 added a commit that referenced this pull request Jun 27, 2024
…ngHeader` using `re_ui::ListItem` (#6657)

### What

- Follow-up to #6637 
- Part of #6655 

This PR completely rewrites the existing `large_collapsing_header` stuff
as follows:
- Renamed `SectionCollapsingHeader`.
- Now a struct with builder pattern, can be created with convenience
`ui.section_collapsing_header("label")`.
- Supports menu button
- Support help tooltip
- Added `ListItem::show_hierarchical_with_children_unindented`.

Note: the label must now be double-clicked to collapse/uncollapse, as
per `ListItem` behaviour.

Few visible changes beyond the help tooltip. The background no longer
changes on hover.

<img width="431" alt="image"
src="https://github.com/rerun-io/rerun/assets/49431240/20be7205-59a3-40a7-9692-c9c2a89ea0b6">


### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6657?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6657?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/6657)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include in changelog ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename blueprint section
3 participants