New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't pass RRD paths to other data-loaders #6617

Merged

teh-cmc merged 1 commit into main from cmc/no_rrd_external

Jun 24, 2024

Member

teh-cmc commented Jun 24, 2024 •

edited by github-actions bot

Loading

Fixes When trying to load an .rrd, all external data loaders are run #6530

Checklist

I have read and agree to Contributor Guide and the Code of Conduct
I've included a screenshot or gif (if applicable)
I have tested the web demo (if applicable):
- Using examples from latest main build: rerun.io/viewer
- Using full set of examples from nightly build: rerun.io/viewer
The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.


          dont pass rrds to other loaders

d301b17

teh-cmc added 😤 annoying include in changelog labels

emilk approved these changes

View reviewed changes

teh-cmc merged commit ba2a8d1 into main

33 of 36 checks passed

teh-cmc deleted the cmc/no_rrd_external branch

June 24, 2024 14:56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

😤 annoying include in changelog