Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS: Make LogChannel public #6529

Merged
merged 2 commits into from
Jun 10, 2024
Merged

JS: Make LogChannel public #6529

merged 2 commits into from
Jun 10, 2024

Conversation

jprochazk
Copy link
Member

@jprochazk jprochazk commented Jun 10, 2024

What

Made LogChannel an export. It was previously part of the public API, but I seem to have made it not exported at some point.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

@jprochazk jprochazk added 🕸️ web regarding running the viewer in a browser exclude from changelog PRs with this won't show up in CHANGELOG.md include in changelog and removed exclude from changelog PRs with this won't show up in CHANGELOG.md labels Jun 10, 2024
@jprochazk jprochazk marked this pull request as ready for review June 10, 2024 10:59
@jprochazk
Copy link
Member Author

Don't want to waste CI time on this

@jprochazk jprochazk merged commit 83b3b46 into main Jun 10, 2024
25 of 30 checks passed
@jprochazk jprochazk deleted the jan/web-viewer-stuff branch June 10, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include in changelog 🕸️ web regarding running the viewer in a browser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant