Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't log SDK client connected message until after we have confirmed it's a client #6456

Merged
merged 1 commit into from
May 29, 2024

Conversation

jleibs
Copy link
Member

@jleibs jleibs commented May 29, 2024

What

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

@jleibs jleibs added enhancement New feature or request 📺 re_viewer affects re_viewer itself include in changelog labels May 29, 2024
@jleibs jleibs marked this pull request as ready for review May 29, 2024 15:05
@jleibs jleibs merged commit ceb929d into main May 29, 2024
37 of 39 checks passed
@jleibs jleibs deleted the jleibs/improve_connection_logs branch May 29, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request include in changelog 📺 re_viewer affects re_viewer itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only log "New SDK client connected" when the incoming TCP connection is verified
2 participants