Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce height of top and bottom panels #6397

Merged
merged 8 commits into from
May 22, 2024
Merged

Reduce height of top and bottom panels #6397

merged 8 commits into from
May 22, 2024

Conversation

emilk
Copy link
Member

@emilk emilk commented May 21, 2024 •
edited
Loading

What

Before

Screenshot 2024-05-21 at 19 58 17 Screenshot 2024-05-21 at 19 58 13

After

Screenshot 2024-05-21 at 19 57 32 Screenshot 2024-05-21 at 19 57 27

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

@emilk emilk added ui concerns graphical user interface include in changelog labels May 21, 2024
teh-cmc
teh-cmc approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@teh-cmc teh-cmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

crates/re_entity_db/src/entity_db.rs
@@ -336,6 +336,14 @@ impl EntityDb {
&self.times_per_timeline
}

pub fn has_any_data_on_timeline(&self, timeline: &Timeline) -> bool {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#[inline] i guess

@emilk
Copy link
Member Author

emilk commented May 22, 2024

Alternatively we adjust the height dynamically, i.e. responding to the viewport size so that they are thin when space is scarce, and thick when there is a lot of space.

@emilk
Copy link
Member Author

emilk commented May 22, 2024

Let's try this

@emilk emilk merged commit 9bb5bb7 into main May 22, 2024
34 checks passed
@emilk emilk deleted the emilk/reduce-vertical-space branch May 22, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teh-cmc teh-cmc teh-cmc approved these changes

Assignees
No one assigned
Labels
include in changelog ui concerns graphical user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emilk @teh-cmc