C++ roundtrip test setup, implement for points3d/arrow3d/disconnected_space #2906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wumpf
added
🧑💻 dev experience
|
worked on my machine, but CI needs a bit of kicking. Let's see if this fares better now |
3 tasks
jleibs
reviewed
Aug 3, 2023
Wumpf
added a commit
that referenced
this pull request
Aug 4, 2023
) ### What Adds C++ example build setup and examples for: * Point3D #2789 * Arrow3D #2785 * DisconnectedSpace #2791 as before Point2D example is blocked on rects for the moment. Generating a bunch more methods now for better usability. Still lacking user extensions though, in particular Point3D construction is poor right now Examples can be built in bulk with ` ./tests/cpp/build_all_doc_examples.sh` Then run with `./build/tests/cpp/doc_example_point3d_EXAMPLE_NAME` They all connect to localhost on default port for now. Point3D Simple: <img width="1336" alt="image" src="https://github.com/rerun-io/rerun/assets/1220815/61ca8dba-690f-4bcf-96d2-25cb010881fb"> Point3D Random: <img width="1341" alt="image" src="https://github.com/rerun-io/rerun/assets/1220815/48fa902d-7858-4580-b64b-69815dab47e3"> Arrow3D: <img width="1360" alt="image" src="https://github.com/rerun-io/rerun/assets/1220815/131d0efa-af94-418a-b08f-653c1d9eafb0"> Disconnected Space: <img width="1339" alt="image" src="https://github.com/rerun-io/rerun/assets/1220815/5da1bb64-984a-4ff5-903a-1ea060dd296a"> Dependent on #2906 ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/2908) (if applicable) - [PR Build Summary](https://build.rerun.io/pr/2908) - [Docs preview](https://rerun.io/preview/pr%3Aandreas%2Fcpp%2Fexamplesv2/docs) - [Examples preview](https://rerun.io/preview/pr%3Aandreas%2Fcpp%2Fexamplesv2/examples)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
C++ is starting to catch up! It's now part of the roundtrip tests. A bunch of types are opted-out at this point since the codegen isn't up for it yet (points3d is opted out because it needs an rect archetype which is coming later today or tomorrow)
Does not yet fix the related tickets, for that we still need examples and custom extensions.
(gonna do examples as the next thing)
Checklist