Remove legacy Transform3D
#2846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teh-cmc
added
🐍 Python API
teh-cmc
force-pushed
the
cmc/goodbye_old_transform
branch
9 times, most recently
from
478c5d1 to
a7f97aa
Compare
teh-cmc
force-pushed
the
cmc/goodbye_old_transform
branch
from
b27608a to
86b41be
Compare
Wumpf
approved these changes
Jul 31, 2023
teh-cmc
force-pushed
the
cmc/goodbye_old_transform
branch
from
de43962 to
8c5510b
Compare
teh-cmc
force-pushed
the
cmc/goodbye_old_transform
branch
from
8c5510b to
12bc870
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR annihilates the legacy
Transform3Dfamily of component and data types, and deprecates the legacyVecND&MatNxNtypes as much as possible (there are still many other components that we have to migrate first).The legacy
log_transform3dAPI still exists, but now simply delegates to the newTransform3Darchetype.This PR also includes some improved error reporting on the deserialization path, as well as a workaround for
pa.nullsmisbehaving in some cases, see #2871 for the full story.This PR also removes any traces of datatypes being registered as UI components, as it historically did not make sense and was never used, and is simply impossible to do anymore since
DatatypeandComponentare now different traits.Part of #2791
What
Checklist