Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always flush when we remove a sink #1830

Merged
merged 4 commits into from
Apr 13, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
I swear I speak english
jleibs committed Apr 13, 2023
commit 33cc46da6c9979f9389904d35d2c371b36f71a4b
2 changes: 1 addition & 1 deletion rerun_py/src/python_session.rs
Original file line number Diff line number Diff line change
@@ -144,7 +144,7 @@ impl PythonSession {
/// If the previous sink is [`rerun::sink::BufferedSink`] (the default),
/// it will be drained and sent to the new sink.
pub fn set_sink(&mut self, sink: Box<dyn LogSink>) {
// Capture the backlog (should only applies if this was a `BufferedSink`)
// Capture the backlog (should only apply if this was a `BufferedSink`)
let backlog = self.sink.drain_backlog();

// Before changing the sink, we set drop_if_disconnected and