Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HalfSizes2D and HalfSizes3D should not be pluralized #6620

Closed
emilk opened this issue Jun 24, 2024 · 2 comments · Fixed by #6768
Closed

HalfSizes2D and HalfSizes3D should not be pluralized #6620

emilk opened this issue Jun 24, 2024 · 2 comments · Fixed by #6768
Assignees
@emilk
Labels
😤 annoying Something in the UI / SDK is annoying to use 🏎️ Quick Issue Can be fixed in a few hours or less

Comments

@emilk
Copy link
Member

emilk commented Jun 24, 2024

All other components have singular names (Color, Radius, …) except for HalfSizes2D and HalfSizes3D.

We should rename them as HalfSize2D and HalfSize3D.
@emilk emilk added 😤 annoying Something in the UI / SDK is annoying to use 🏎️ Quick Issue Can be fixed in a few hours or less labels Jun 24, 2024
@Vale2901

This comment was marked as off-topic.

Sign in to view
@Vale2901

This comment was marked as off-topic.

Sign in to view
@emilk emilk self-assigned this Jul 4, 2024
@emilk emilk mentioned this issue Jul 4, 2024
Merged
5 tasks
@emilk emilk closed this as completed in af680b1 Jul 5, 2024
abey79 pushed a commit that referenced this issue Jul 5, 2024
@emilk @abey79
Rename HalfSizes2D/3D to HalfSize2D/3D (#6768)
9328185 
### What
We use the singular for every other component.

* Closes #6620

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6768?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6768?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/6768)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.
facebook-github-bot pushed a commit to facebookincubator/momentum that referenced this issue Jul 11, 2024
@SeaOtocinclus @facebook-github-bot
Update to 0.17
8ebe5a1 
Summary:
Update from 0.16 to 0.17
see https://my.workplace.com/groups/rerunext/permalink/987843470010215/ for details

Fixing API change:
- rerun::HalfSizes3D -> rerun::HalfSize3D -- rerun-io/rerun#6620

Differential Revision: D59531309

fbshipit-source-id: f53a45e20597f0cb0bee3dc886fae560b9e2df53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emilk emilk

Labels
😤 annoying Something in the UI / SDK is annoying to use 🏎️ Quick Issue Can be fixed in a few hours or less
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename HalfSizes2D/3D to HalfSize2D/3D rerun-io/rerun
2 participants
@emilk @Vale2901