Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add roundtrip tests for Axes3D archetype #6525

Closed
emilk opened this issue Jun 10, 2024 · 1 comment
Closed

Add roundtrip tests for Axes3D archetype #6525

emilk opened this issue Jun 10, 2024 · 1 comment
Labels
🔨 testing testing and benchmarks
Milestone

Comments

@emilk
Copy link
Member

emilk commented Jun 10, 2024

@emilk emilk added the 🔨 testing testing and benchmarks label Jun 10, 2024
@emilk emilk added this to the 0.17 milestone Jun 10, 2024
@emilk
Copy link
Member Author

emilk commented Jun 10, 2024

#6524 (comment)

@emilk emilk closed this as not planned Won't fix, can't repro, duplicate, stale Jun 10, 2024
emilk added a commit that referenced this issue Jun 10, 2024
`main` CI is failing:
https://github.com/rerun-io/rerun/actions/runs/9436507239/job/25991550784

#6510 added a new archetype
(`Axes3D`) without adding roundtrip tests for it. This was easily missed
because the PR CI doesn't run the roundtrip tests.

This PR adds a fast PR CI check to make sure we have roundtrip tests for
all archetype, but without paying the cost of actually running them. The
failure looks like this:


![image](https://github.com/rerun-io/rerun/assets/1148717/61bf60b6-4a88-4f13-be65-917741d7aff8)

This PR also adds an exception for the `Axes3D` archetype. I've created
a separate issue for that, adding it to this cycle:
* #6525

---

* [x] I love checkboxes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 testing testing and benchmarks
Projects
None yet
Development

No branches or pull requests

1 participant