Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update DataResultTree to start at origin and introduce "projected" subspace #4156

Closed
Tracked by #4899
jleibs opened this issue Nov 6, 2023 · 1 comment · Fixed by #5342
Closed
Tracked by #4899

Update DataResultTree to start at origin and introduce "projected" subspace #4156

jleibs opened this issue Nov 6, 2023 · 1 comment · Fixed by #5342
Assignees
@Wumpf
Labels
🟦 blueprint The data that defines our UI ui concerns graphical user interface

Comments

@jleibs
Copy link
Member

jleibs commented Nov 6, 2023 •
edited
Loading

As part of #4899 we need to update the way that the DataResultTree is presented in the UI:

  • The top-most entity in the group should always be the $origin of the SpaceView.
  • Any items that are not part of the $origin should instead be in a separate "Projected" sub-space that starts at "/" instead of $originl.

Mock-up of future UI:
image
@jleibs jleibs added 🟦 blueprint The data that defines our UI 📺 re_viewer affects re_viewer itself ui concerns graphical user interface and removed ui concerns graphical user interface 📺 re_viewer affects re_viewer itself labels Nov 6, 2023
@jleibs jleibs mentioned this issue Nov 6, 2023
Closed
6 tasks
@jleibs jleibs mentioned this issue Dec 12, 2023
Closed
@nikolausWest nikolausWest mentioned this issue Jan 23, 2024
Open
2 tasks
@jleibs jleibs changed the title Improved Design for display of DataResultTree in blueprint panel Update DataResultTree to remove "groups and introduce "projected" subspace Feb 26, 2024
@jleibs jleibs mentioned this issue Feb 26, 2024
Open
3 tasks
@jleibs jleibs changed the title Update DataResultTree to remove "groups and introduce "projected" subspace Update DataResultTree to start at origin, remove "groups", and introduce "projected" subspace Feb 26, 2024
@jleibs
Copy link
Member Author

jleibs commented Feb 26, 2024

For visibillity: start with simplest behavior: visibillity for an entity -> hides entity + children.

This regresses our current abillity to hide a parent entity, while leaving the "group" (including children) visible.

We will need to introduce new UI mechanism to handle the complexity of self vs self+children.

@jleibs jleibs changed the title Update DataResultTree to start at origin, remove "groups", and introduce "projected" subspace Update DataResultTree to start at origin and introduce "projected" subspace Feb 26, 2024
@Wumpf Wumpf mentioned this issue Feb 28, 2024
Merged
5 tasks
Wumpf added a commit that referenced this issue Feb 29, 2024
@Wumpf
Blueprint tree always starts at the origin now, "projected" paths are…
c413bd5 
… called out explicitely (#5342)

### What

* Direct follow up of #5326
* Fixes #4156 


https://github.com/rerun-io/rerun/assets/1220815/77ed6a42-50db-4ca3-b596-8dcf5bce9baf


Follows the design proposal from the ticket directly. Some detail
decisions on how things are exactly handled, but code should be a bit
more composable now (albeit admittedly still a bit messy)

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/5342/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/5342/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/5342/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/5342)
- [Docs
preview](https://rerun.io/preview/6011f651a1ebd432d77d25d3edd7ea746053fd99/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/6011f651a1ebd432d77d25d3edd7ea746053fd99/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Wumpf Wumpf

Labels
🟦 blueprint The data that defines our UI ui concerns graphical user interface
Projects
None yet
Milestone
No milestone
2 participants
@Wumpf @jleibs