Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

From visual history to a general time query #3933

Closed
nikolausWest opened this issue Oct 19, 2023 · 1 comment · Fixed by #4123
Closed

From visual history to a general time query #3933

nikolausWest opened this issue Oct 19, 2023 · 1 comment · Fixed by #4123
Assignees
@abey79
Labels
🟦 blueprint The data that defines our UI enhancement New feature or request 🔍 re_query affects re_query itself 📺 re_viewer affects re_viewer itself
Milestone
0.11

Comments

@nikolausWest
Copy link
Member

nikolausWest commented Oct 19, 2023 •
edited
Loading

We currently allow users to set visual history on any data in the blueprint:

visual.history.drag.mp4

This is somewhat useful but could be made much more powerful if we expanded this to be a more general time query. You should be able to:
@nikolausWest nikolausWest added enhancement New feature or request 📺 re_viewer affects re_viewer itself 🔍 re_query affects re_query itself 🟦 blueprint The data that defines our UI labels Oct 19, 2023
@nikolausWest nikolausWest added this to the 0.11 C++ polish milestone Oct 19, 2023
@abey79 abey79 mentioned this issue Nov 2, 2023
Merged
7 tasks
@abey79
Copy link
Member

abey79 commented Nov 2, 2023

#4123 adds support for specifying more general time ranges.

For the rest, I've started a proper tracking issue:

@abey79 abey79 mentioned this issue Nov 2, 2023
Open
22 tasks
abey79 added a commit that referenced this issue Nov 6, 2023
@abey79 @Wumpf
Improve Visible History to support more general time queries (#4123)
ce2493c 
### What

* Fixes #3933

<img width="1971" alt="image"
src="https://github.com/rerun-io/rerun/assets/49431240/8d51f828-cab8-4940-9a2a-a35841fb7fe2">


#### Scope
- Improve the "Visible History" feature to build more general time
queries:
  - Control both start/end time boundaries
  - relative/absolute/full mode for each boundaries
  - explicit active/inactive state/checkbox
- Improve usability:
  - Proper scaling and bounds for the 'DragValue` widgets 
- Proper cascading behaviour from data group(s) to entity: a child's
"visible history" settings will override the parent's if the feature is
active.
  - Do not display Visible History UI in places where it's not supported

#### Out-of-scope
- Add support for Visible History to space views other than 2D/3D
- Add Visible History UI to 3D/2D space view themselves (for consistency
with what precedes and to address some corner cases)
- Add (read-only) shading in the time panel
- Fix the numerous issues/missing features listed in:
  - #4107

#### TODO
- [x] fine-tune the UI layout
- [x] discuss/implement heuristics to decide whether or not to display
the UI
- [x] add information notices (e.g. "this applies to ALL sequence
timelines")

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/4123) (if
applicable)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/4123)
- [Docs
preview](https://rerun.io/preview/6bc0ba72dc79b5af782d73cbabb09b670c59b7e3/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/6bc0ba72dc79b5af782d73cbabb09b670c59b7e3/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://ref.rerun.io/dev/bench/)
- [Wasm size tracking](https://ref.rerun.io/dev/sizes/)

---------

Co-authored-by: Andreas Reich <andreas@rerun.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abey79 abey79

Labels
🟦 blueprint The data that defines our UI enhancement New feature or request 🔍 re_query affects re_query itself 📺 re_viewer affects re_viewer itself
Projects
None yet
Milestone
0.11
Development

Successfully merging a pull request may close this issue.

Improve Visible History to support more general time queries rerun-io/rerun
2 participants
@nikolausWest @abey79