Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct unicode symbols for keyboard shortcut hints #2862

Closed
2 tasks done
Tracked by #2670
martenbjork opened this issue Jul 28, 2023 · 1 comment · Fixed by emilk/egui#3186
Closed
2 tasks done
Tracked by #2670

Use correct unicode symbols for keyboard shortcut hints #2862

martenbjork opened this issue Jul 28, 2023 · 1 comment · Fixed by emilk/egui#3186

Comments

@martenbjork
Copy link
Contributor

martenbjork commented Jul 28, 2023

We currently use the wrong symbol for ctrl. It's not the thin caret that we have on our keyboards (on the 6 key), it's a wider, more geometric arrow.

image

TODO

Update the text strings to use the correct unicode symbol

  • Tooltips
  • Menus

Tip: Maybe create a helper function for this to avoid hard coding the unicode symbol everywhere?

keyboard_shortcut(["ctrl", "command", "P") => ⌘⇧P?

Reference

For reference, these are the correct unicode symbols (they can be copy/pasted)

Command (or Cmd) ⌘
Shift ⇧
Option (or Alt) ⌥
Control (or Ctrl) ⌃
Caps Lock ⇪

@abey79
Copy link
Member

abey79 commented Jul 28, 2023

This needs fixing in egui, and then it'll be fool-proof. It'll take an egui release and a dependency version bump here for this to show up in demos, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants