Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable ranges / (spatial) extent in image and tensor view #1510

Open
Tracked by #1511
tfachmann opened this issue Mar 5, 2023 · 5 comments
Open
Tracked by #1511

Configurable ranges / (spatial) extent in image and tensor view #1510

tfachmann opened this issue Mar 5, 2023 · 5 comments
Labels
enhancement New feature or request 📺 re_viewer affects re_viewer itself

Comments

@tfachmann
Copy link

I was fiddling around with rerun and see large potential to use it for data analysis in our field where I would like to replace matplotlib by rerun. Selecting dimensions to slice through is pretty awesome!

image

To actually use it (i.e. extracting coordinates intuitively, slicing through the actual dimension) I would like to have an option to add an extent (or axis limits) similar to matplotlib: https://matplotlib.org/stable/tutorials/intermediate/imshow_extent.html

The option to add axes and a grid would help as well.

Note: the data I'm visualizing here is 3D (X, Y, Z in meter) with some quality.

It is related to #683

@tfachmann tfachmann added enhancement New feature or request 👀 needs triage This issue needs to be triaged by the Rerun team labels Mar 5, 2023
@nikolausWest
Copy link
Member

Hey @tfachmann! Thanks for opening this issue and really fantastic to hear you see a large potential in Rerun!

It's almost funny that this issue came in during this weekend because on Friday, we aligned internally around that during the next 6 weeks, Rerun should become a completely valid and significantly better alternative to imshow. The first week or two will be spent mostly on laying the ground work so I can't promise when this particular issue will be solved, but at least know it's a top priority for us right now.

@nikolausWest nikolausWest added 📺 re_viewer affects re_viewer itself and removed 👀 needs triage This issue needs to be triaged by the Rerun team labels Mar 5, 2023
@tfachmann
Copy link
Author

Cool, nice to hear it aligns with what you're trying tackle anyway! Looking forward for upcoming releases and can't wait to show it in our institute 🚀

@emilk
Copy link
Member

emilk commented Mar 11, 2023

So what you are asking for is basically a cropping of the tensor, correct?

Do you want/need this to be precise, or do you really just want to zoom in to the tensor?

@tfachmann
Copy link
Author

In my case, not really (it may be that it is not 100% extent what I'm looking for). I basically want to give real world coordinates to my data (per axis). E.g. I know that my X axis starts at -1.5 meter and ends at 1.2 meter. For hovering / slicing and other operations I would expect rerun to show the respective values of the given Dimension instead of simple ranges e.g. 0-250 that I must calculate back manually

@emilk
Copy link
Member

emilk commented Mar 11, 2023

Ah I see - you want to map the tensor indices to some other coordinate system. This could perhaps be handled by the transform system then.

Thanks for the clarification!

Wumpf pushed a commit that referenced this issue Jul 29, 2024
<!--
Open the PR up as a draft until you feel it is ready for a proper
review.

Do not make PR:s from your own `main` branch, as that makes it difficult
for reviewers to add their own fixes.

Add any improvements to the branch as new commits to make it easier for
reviewers to follow the progress. All commits will be squashed to a
single commit once the PR is merged into `main`.

Make sure you mention any issues that this PR closes in the description,
as well as any other related issues.

To get an auto-generated PR description you can put "copilot:summary" or
"copilot:walkthrough" anywhere.
-->

### What

This PR adds a new colormap: cyan to yellow. The colormap is designed to
work well for red-green colorblind people and make it easy to see the
sign and magnitude of values in the range -1 to 1. It is dark and dull
in the middle and bright and colorful at the ends.


![image](https://github.com/user-attachments/assets/ac171ae1-ab77-4134-8b71-424cf8c76f13)
This screenshot is from https://www.shadertoy.com/view/lfByRh.


![image](https://github.com/user-attachments/assets/b40a7bbc-27fd-4ff7-ac43-fe291eb4d1b9)
This screenshot is from the signed distance field example. The
normalization of values interferes with the colormap as it shifts the
center of the colormap away from zero. It will become easier to use it
to its full potential when range controls for colormaps are added. This
problem is related to #6106 and #1510.

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [ ] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/7001?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/7001?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [ ] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [ ] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!
* [ ] If have noted any breaking changes to the log API in
`CHANGELOG.md` and the migration guide

- [PR Build Summary](https://build.rerun.io/pr/{{pr.number}})
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.
@Wumpf Wumpf changed the title Configurable ranges / extent in image and tensor view Configurable ranges / (spatial) extent in image and tensor view Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request 📺 re_viewer affects re_viewer itself
Projects
None yet
Development

No branches or pull requests

3 participants