Remove unused scalar scattering component

rerun-io · May 31, 2024 · 8001b46 · 8001b46
1 parent 707b037
commit 8001b46
Show file tree

Hide file tree

Showing 17 changed files with 1 addition and 262 deletions.
diff --git a/crates/re_edit_ui/src/lib.rs b/crates/re_edit_ui/src/lib.rs
@@ -11,7 +11,7 @@ mod visible;
 // ----
 
 use egui::NumExt as _;
-use re_types::components::{Color, MarkerSize, Name, Radius, ScalarScattering, StrokeWidth, Text};
+use re_types::components::{Color, MarkerSize, Name, Radius, StrokeWidth, Text};
 use re_viewer_context::ViewerContext;
 
 // ----
@@ -43,23 +43,6 @@ fn edit_name_ui(_ctx: &ViewerContext<'_>, ui: &mut egui::Ui, value: &mut Name) -
     response
 }
 
-fn edit_scatter_ui(
-    _ctx: &ViewerContext<'_>,
-    ui: &mut egui::Ui,
-    value: &mut ScalarScattering,
-) -> egui::Response {
-    let scattered_text = if value.0 { "Scattered" } else { "Line" };
-
-    let outer_response = egui::ComboBox::from_id_source("scatter")
-        .selected_text(scattered_text)
-        .show_ui(ui, |ui| {
-            ui.selectable_value(&mut value.0, false, "Line")
-                | ui.selectable_value(&mut value.0, true, "Scattered")
-        });
-
-    outer_response.inner.unwrap_or(outer_response.response)
-}
-
 fn edit_radius_ui(
     _ctx: &ViewerContext<'_>,
     ui: &mut egui::Ui,
@@ -113,7 +96,6 @@ pub fn register_editors(registry: &mut re_viewer_context::ComponentUiRegistry) {
     registry.add_editor(edit_marker_size_ui);
     registry.add_editor(edit_name_ui);
     registry.add_editor(edit_radius_ui);
-    registry.add_editor(edit_scatter_ui);
     registry.add_editor(edit_stroke_width_ui);
     registry.add_editor(edit_text_ui);
     registry.add_editor(visible::edit_visible);

diff --git a/crates/re_types/definitions/rerun/components.fbs b/crates/re_types/definitions/rerun/components.fbs
@@ -25,7 +25,6 @@ include "./components/range1d.fbs";
 include "./components/resolution.fbs";
 include "./components/rotation3d.fbs";
 include "./components/scalar.fbs";
-include "./components/scalar_scattering.fbs";
 include "./components/stroke_width.fbs";
 include "./components/tensor_data.fbs";
 include "./components/texcoord2d.fbs";

diff --git a/crates/re_types/definitions/rerun/components/scalar_scattering.fbs b/crates/re_types/definitions/rerun/components/scalar_scattering.fbs
diff --git a/crates/re_types/src/components/.gitattributes b/crates/re_types/src/components/.gitattributes
diff --git a/crates/re_types/src/components/mod.rs b/crates/re_types/src/components/mod.rs
diff --git a/crates/re_viewer/src/component_defaults/mod.rs b/crates/re_viewer/src/component_defaults/mod.rs
diff --git a/docs/content/reference/types/components.md b/docs/content/reference/types/components.md
diff --git a/docs/content/reference/types/components/.gitattributes b/docs/content/reference/types/components/.gitattributes
diff --git a/docs/content/reference/types/components/scalar_scattering.md b/docs/content/reference/types/components/scalar_scattering.md
diff --git a/rerun_cpp/src/rerun/components.hpp b/rerun_cpp/src/rerun/components.hpp
diff --git a/rerun_cpp/src/rerun/components/.gitattributes b/rerun_cpp/src/rerun/components/.gitattributes
diff --git a/rerun_cpp/src/rerun/components/scalar_scattering.cpp b/rerun_cpp/src/rerun/components/scalar_scattering.cpp
diff --git a/rerun_cpp/src/rerun/components/scalar_scattering.hpp b/rerun_cpp/src/rerun/components/scalar_scattering.hpp
diff --git a/rerun_py/rerun_sdk/rerun/components/.gitattributes b/rerun_py/rerun_sdk/rerun/components/.gitattributes
diff --git a/rerun_py/rerun_sdk/rerun/components/__init__.py b/rerun_py/rerun_sdk/rerun/components/__init__.py
diff --git a/rerun_py/rerun_sdk/rerun/components/scalar_scattering.py b/rerun_py/rerun_sdk/rerun/components/scalar_scattering.py
diff --git a/tests/python/release_checklist/check_all_components_ui.py b/tests/python/release_checklist/check_all_components_ui.py
@@ -137,7 +137,6 @@ def alternatives(self) -> list[Any] | None:
         ]
     ),
     "ScalarBatch": TestCase(3),
-    "ScalarScatteringBatch": TestCase(True),
     "StrokeWidthBatch": TestCase(2.0),
     "TensorDataBatch": TestCase(
         alternatives=[