Skip to content

Docs for InstanceCreationOptions #527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

304NotModified
Copy link
Contributor

@304NotModified 304NotModified commented Mar 12, 2025

πŸ€” What's changed?

Added docs for InstanceCreationOptions

⚑️ What's your motivation?

fixes #514

Also changed one test to assert the message

🏷️ What kind of change is this?

  • πŸ“– Documentation (improvements without changing code)

♻️ Anything particular you want feedback on?

@304NotModified 304NotModified marked this pull request as ready for review March 12, 2025 10:29
@304NotModified 304NotModified added the documentation Improvements or additions to documentation label Mar 12, 2025
Copy link
Contributor

@gasparnagy gasparnagy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super. Ready to merge?

@304NotModified
Copy link
Contributor Author

Yes, please check "Anything particular you want feedback on?" Thanks!

@gasparnagy
Copy link
Contributor

Yes, please check "Anything particular you want feedback on?" Thanks!

OK. No worries. I think this is the best place to document it. I'm also not native English and I have understood what you wrote, so it is good enough for sure πŸ˜‰.

@gasparnagy gasparnagy merged commit 5908cce into reqnroll:main Mar 13, 2025
6 checks passed
@304NotModified 304NotModified deleted the docs-InstanceCreationOptions branch March 13, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document InstanceCreationOptions class for assist helpers
2 participants