Include original exception in when throwing a BindingException #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please add an unit test for this? |
…Exception It should help with #471, I think the `catch (ArgumentException)` should be reworked, but this is a very quick improvement that will keep the stack readable in the test output.
|
I updated the existing test |
|
Released in 2.4.0: https://github.com/orgs/reqnroll/discussions/515 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
Include original exception in when throwing a BindingException
⚡️ What's your motivation?
Imrprove error message and don't hide the stack when an error occurs. It should help #471 (But I think the catch ArgumentException should still be reworked)
🏷️ What kind of change is this?