Improved message when [ScenarioDependencies] can't be found or has an incorrect return type (Reqnroll.Microsoft.Extensions.DependencyInjection)

[304NotModified]

🤔 What's changed?

For Reqnroll.Microsoft.Extensions.DependencyInjection improved the message when [ScenarioDependencies] can't be found

• Tell it should be static (and could be non-public)
• Tell the scanned assemblies
• Don't give a "System.ArgumentNullException : Value cannot be null" when returning the wrong type / void methods

The new messages are (see also unit tests)

• [ScenarioDependencies] should return IServiceCollection but the method doesn't return a value.
• [ScenarioDependencies] should return IServiceCollection but returned null.
• [ScenarioDependencies] should return IServiceCollection but returned System.Collections.Generic.List`1[System.String].
• No method marked with [ScenarioDependencies] attribute found. It should be a (public or non-public) static method. Scanned assemblies: Reqnroll.PluginTests.

Nothing has been changed with the behavior of the code in the happy path. I have considered scanned non-static methods, but because the current code scans all types and all static (public and private methodes) in the assembly until one is found, I don't think that is a good idea for the performance.

I also fixed the Virtual call in ctor for MissingScenarioDependenciesException.

⚡️ What's your motivation?

Fixes #474

🏷️ What kind of change is this?

• 🏦 Refactoring/debt/DX (improvement to code design, tooling, etc. without changing behaviour)

♻️ Anything particular you want feedback on?

• Do you also think the change to prevent the virtual call in the ctor is the best option?
• Are the messages clear?

📋 Checklist:

• I've changed the behaviour of the code
  • I have added/updated tests to cover my changes.
  • I have added an entry to the "[vNext]" section of the CHANGELOG, linking to this pull request & included my GitHub handle to the release contributors list.

---

This text was originally taken from the template of the Cucumber project, then edited by hand. You can modify the template here.

[gasparnagy]

Looks good.

[gasparnagy]

Released in 2.4.0: https://github.com/orgs/reqnroll/discussions/515