Log exception claass name when 500 occures

replay-framework · Dec 16, 2023 · 7794680 · 7794680
1 parent c0018b9
commit 7794680
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 7 deletions.
diff --git a/javanet/src/play/server/javanet/PlayHandler.java b/javanet/src/play/server/javanet/PlayHandler.java
@@ -534,7 +534,6 @@ private void printResponse(HttpExchange exchange, int httpStatus, String content
 
   private void serve500(Exception e, HttpExchange exchange, Http.Request request, Http.Response response) {
     logger.trace("serve500: begin");
-    logger.error("Exception on request. serving 500 back", e);
 
     try {
       flushCookies(exchange, response);
@@ -545,10 +544,10 @@ private void serve500(Exception e, HttpExchange exchange, Http.Request request,
       try {
         String errorHtml = serverHelper.generateErrorResponse(request, format, e);
         printResponse(exchange, INTERNAL_ERROR, contentType, errorHtml);
-        logger.error("Internal Server Error (500) for request {} {}", request.method, request.url, e);
+        logger.error("Internal Server Error (500) for {} {} ({})", request.method, request.url, e.getClass().getSimpleName(), e);
       }
       catch (Throwable ex) {
-        logger.error("Internal Server Error (500) for request {} {}", request.method, request.url, e);
+        logger.error("Internal Server Error (500) for {} {} ({})", request.method, request.url, e.getClass().getSimpleName(), e);
         logger.error("Error during the 500 response generation", ex);
         sendServerError(exchange, request);
       }

diff --git a/netty3/src/play/server/netty3/PlayHandler.java b/netty3/src/play/server/netty3/PlayHandler.java
@@ -616,9 +616,9 @@ private void serve500(Exception e, ChannelHandlerContext ctx, Request request, R
                 nettyResponse.setContent(buf);
                 ChannelFuture writeFuture = ctx.getChannel().write(nettyResponse);
                 writeFuture.addListener(ChannelFutureListener.CLOSE);
-                logger.error("Internal Server Error (500) for request {} {}", request.method, request.url, e);
+                logger.error("Internal Server Error (500) for {} {} ({})", request.method, request.url, e.getClass().getSimpleName(), e);
             } catch (Throwable ex) {
-                logger.error("Internal Server Error (500) for request {} {}", request.method, request.url, e);
+                logger.error("Internal Server Error (500) for {} {} ({})", request.method, request.url, e.getClass().getSimpleName(), e);
                 logger.error("Error during the 500 response generation", ex);
                 byte[] bytes = "Internal Error".getBytes(encoding);
                 ChannelBuffer buf = ChannelBuffers.copiedBuffer(bytes);

diff --git a/netty4/src/play/server/netty4/PlayHandler.java b/netty4/src/play/server/netty4/PlayHandler.java
@@ -601,9 +601,9 @@ private void serve500(Exception e, ChannelHandlerContext ctx, Request request, R
                 nettyResponse = nettyResponse.replace(buf);
                 ChannelFuture writeFuture = ctx.channel().writeAndFlush(nettyResponse);
                 writeFuture.addListener(ChannelFutureListener.CLOSE);
-                logger.error("Internal Server Error (500) for request {} {}", request.method, request.url, e);
+                logger.error("Internal Server Error (500) for {} {} ({})", request.method, request.url, e.getClass().getSimpleName(), e);
             } catch (Throwable ex) {
-                logger.error("Internal Server Error (500) for request {} {}", request.method, request.url, e);
+                logger.error("Internal Server Error (500) for {} {} ({})", request.method, request.url, e.getClass().getSimpleName(), e);
                 logger.error("Error during the 500 response generation", ex);
                 byte[] bytes = "Internal Error".getBytes(encoding);
                 ByteBuf buf = Unpooled.copiedBuffer(bytes);